Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make volumes-per-node limit configurable [CON-10973] #575

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

timoreimann
Copy link
Contributor

This is to support a future DO block storage volume limit increase.

Adjusting the limit in the driver is to allow the Kubernetes scheduler to work correctly mostly. Specifically, it won't have an influence on what the DO storage backend permits. The two need to be synchronized.

This is to support a future DO block storage volume limit increase.

Adjusting the limit in the driver is to allow the Kubernetes scheduler
to work correctly mostly. Specifically, it won't have an influence on
what the DO storage backend permits. The two need to be synchronized.
@timoreimann timoreimann marked this pull request as ready for review July 31, 2024 08:34
Copy link

@m3co-code m3co-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not even sth wort a nit-pick :3

Awesome to see such a short cycle time from discussion to implementation.

@timoreimann timoreimann merged commit 020ea8c into master Aug 7, 2024
3 checks passed
@timoreimann timoreimann deleted the make-volume-limit-configurable branch August 7, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants